Mostly finish pytest to Bats conversion #1200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finalizes the conversion from Pytest to Bats, mostly so coverage can be calculated. Big shoutout to @vanpipy for making the original tests, which made things easier.
Code coverage is mentioned in the testing README.md. I got it to work with bashcov:
coverage/index.htmllooks like this:This is what opening a file looks like:
I wasn't able to get kcov to work, unfortunately. If anyone else is able to figure that out, I would appreciate it. But bashcov seems to work fine.
I updated CI to move the Bats testing to a separate job because it speeds things up, testing in parallel.