Skip to content

Conversation

@hyperupcall
Copy link
Collaborator

@hyperupcall hyperupcall commented Mar 24, 2025

This finalizes the conversion from Pytest to Bats, mostly so coverage can be calculated. Big shoutout to @vanpipy for making the original tests, which made things easier.

Code coverage is mentioned in the testing README.md. I got it to work with bashcov:

bashcov -- bats ./tests

coverage/index.html looks like this:

image

This is what opening a file looks like:

image

I wasn't able to get kcov to work, unfortunately. If anyone else is able to figure that out, I would appreciate it. But bashcov seems to work fine.

I updated CI to move the Bats testing to a separate job because it speeds things up, testing in parallel.

@hyperupcall hyperupcall marked this pull request as ready for review March 24, 2025 08:13
@hyperupcall hyperupcall marked this pull request as draft March 24, 2025 08:13
@hyperupcall hyperupcall force-pushed the hyperupcall-bats-mostly-finish branch from ab330a5 to e8a1f94 Compare March 24, 2025 08:14
@hyperupcall hyperupcall force-pushed the hyperupcall-bats-mostly-finish branch from e8a1f94 to e2ea966 Compare March 24, 2025 08:16
@hyperupcall hyperupcall marked this pull request as ready for review March 24, 2025 08:17
@spacewander spacewander merged commit c49ca70 into tj:main Mar 26, 2025
6 checks passed
@spacewander
Copy link
Collaborator

@hyperupcall
Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants