fix(git-bulk): quiet find errors by default #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperupcall
approved these changes
Feb 20, 2025
Collaborator
hyperupcall
left a comment
hyperupcall
left a comment
There was a problem hiding this comment.
Agreed, sounds reasonable to me!
spacewander
approved these changes
Feb 20, 2025
Collaborator
|
@pierreay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be a bad experience for a user to see a bunch of find errors (e.g., file name too long, no permissions, etc.) when using
git-bulk. I feel like it is not the job of the tool to report all errors thatfindcan throws when searching all files under a hierarchy. Therefore, I quiet thefinderrors by default in this PR. If showing its errors is really on purpose, maybe we could create a flag to do so?