Skip to content

chore: Various Bash improvements #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spacewander merged 1 commit into from
Feb 3, 2023
Merged

chore: Various Bash improvements #1029

spacewander merged 1 commit into from
Feb 3, 2023

Conversation

@hyperupcall
Copy link
Collaborator

@hyperupcall hyperupcall commented Jan 31, 2023 •
edited
Loading

They mostly include

  • Use $PWD instead of $(pwd)
  • Better quoting
  • [ -n instead of [ ! -z
  • Adding -r to read

@hyperupcall hyperupcall changed the title chore: Various improvements chore: Various Bash improvements Jan 31, 2023
@spacewander spacewander merged commit 75d0dbf into tj:master Feb 3, 2023
@hyperupcall hyperupcall deleted the bash-improvements branch August 26, 2023 08:02
vanpipy pushed a commit to vanpipy/git-extras that referenced this pull request Sep 14, 2023
@hyperupcall @vanpipy
chore: Various Bash improvements (tj#1029)
3446a3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyperupcall @spacewander