chore: Fix more Bash inconsistencies #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
guenhter
reviewed
Jan 16, 2023
| } | ||
|
|
||
| while [[ $# > 0 ]] | ||
| while [[ $# -gt 0 ]] |
Contributor
There was a problem hiding this comment.
Why was this changed? > is be perfectly and expressive find within [[ ... ]], isn't it?
Collaborator
Author
There was a problem hiding this comment.
> and < perform lexicographical comparison rather than a numerical comparison in this context, so it was changed to -gt
Contributor
There was a problem hiding this comment.
I see. Thx for the explanation. With this new knowledge I now have to have a look at some of my own scripts as well :)
spacewander
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly fixes the following:
git-touch,git-scp), but variables like$BRANCHare.-rtoreadinvocations$(echo $(printf '%s\n' 'thing'))is changed to$(printf '%s\n' 'thing')