Upgrade ZSH completion

[GuillaumeSeren]

Hey there,
I open a new issue to start from something fresh, but this follow (few years laters) this issue: #70

So to sum up I am a git-extras user, which recently switch from bash to zsh.

So after digging on the web, I realized that the zsh completion file is not the same in bash, and is not up-to-date by 3 year old:

• https://github.com/robbyrussell/oh-my-zsh/blob/master/plugins/git-extras/git-extras.plugin.zsh

So despite the fact it is quite disappointing to see that breaking, I try to use the bash completion file with zsh with no success, so I think upgrading the zsh completion is not a big deal, so started it.

While it's not finish, I am really asking if you (there's probably other zsh user), find a way to get the completion working ?

Other question, what do do you think about getting this file here in the upstream project ?

Guillaume.

[hemanth]

Definitely.

[spacewander]

@GuillaumeSeren
Long time ago, I have seen a pr to oh-my-zsh to update the git-extras completion: ohmyzsh/ohmyzsh#3408

It have not been merged because of the conflict with gitfast plugin, and now it is far behind the development of git-extras, too.

IMHO, I think this zsh completion script should only depend on zsh itself, to avoid unpredictable conflict with other completion script.

[GuillaumeSeren]

Ok thank for your quick feedback @hemanth , I've upgrade a good 30% of the functions but if I will reply here when it's done.

[GuillaumeSeren]

@spacewander Oh great !
I will test it, and add my feedback on your PR.

I've upgrade the whole command list and maybe if I implement each missing command it's quite some work, so maybe I can add my work on your PR but if they do not want your upgrade maybe I will have the same issue.

I use antigen to load only needed plugin but if both define the same completion, it may override on option or an other :/

About where keeping the completion file, I think the best should be the upstream because it's easier to find and maintain, but I just discovered this part of zsh, and maybe I miss something, but I find it strange to have an other layer between upstream and you, so at least hosting it here will prevent, from conflicts with other git plugin in oh-my-zsh (and there is a lot).

Doing this way will not prevent, user community to make their own version at all, it's quite new for I was to much used to the bash system.

For an additional example I suggest to have a look at the zsh completion for git upstream vs oh-my-zsh:

• upstream: https://github.com/git/git/blob/master/contrib/completion/git-completion.zsh
• oh-my-zsh: https://github.com/robbyrussell/oh-my-zsh/tree/master/plugins/git

Guillaume.

[teto]

Hi,
I get a bit confused by the discussion, what's the authorative/recommended completion script ? Even if outdated, shouldn't it be upstream so that contributors can help ?

[spacewander]

@teto @hemanth @qw3rtman @nicolaiskogheim
Maybe we can place the completion script here and tell the user to copy it into $fpath after installation.

[teto]

fine by me, looks like what most projects do

2016-07-18 16:26 GMT+02:00 罗泽轩 notifications@github.com:

@teto https://github.com/teto @hemanth https://github.com/hemanth
@qw3rtman https://github.com/qw3rtman @nicolaiskogheim
https://github.com/nicolaiskogheim
Maybe we can place the completion script here and tell the user to copy it
into $fpath after installation.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#376 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA2FOlMCUWKULHKwpZ56PKDl-0kglDiZks5qW40cgaJpZM4EqS4E
.

[GuillaumeSeren]

@spacewander I just arrived, but happy to see some activity on this issue !

I agree the best way should be to keep a basic completion script in the upstream source,
and if we have better or we want to override that according to the zsh way we can put it in the userspace.

That way we still can have userspace libs to have 'our own' completion but upstream can provide one, and it can easier for people to commit back upgrade to upstream.

[GuillaumeSeren]

@spacewander
I've just checked again the git project and they added the zsh and tcsh completion file in the upstrream,
so maybe it should be 'a safe move' to follow that practice here !

cf: https://github.com/git/git/tree/master/contrib/completion

[spacewander]

I have submitted a zsh completion script in pr #551
What we need is just source it in ~/.zshrc.

[GuillaumeSeren]

Thank you @spacewander !
I will test it, instead of the zsh module, but I think this is really the best way (simplest) to do it,
when I switch to zsh, I start complaining about that people tell me "That's the zsh way",
I was disapointing wich, in the end, lead me to creating this issue.

I am happy to see there no only one road here !