git effort bad substitution error

[ifduyue]

Hello,

/opt/homebrew/bin/git-effort: line 272:  ${nJobs@P} >= nProcs : bad substitution

related code:

# send paths to effort
nPaths=${#paths[@]}
nProcs=$(procs)
nJobs="\j"
for ((i=0; i<nPaths; ++i))
do
    while (( ${nJobs@P} >= nProcs )); do
        wait -n
    done
    effort "${paths[i]}" &
done|tee $tmp

What does nJobs="\j" mean?

[spacewander]

It's Bash's PROMPTING syntax. For example, \H means "the hostname", \j means "the number of jobs currently managed by the shell". You can find them in man bash.

What shell are you using?

[zijie0]

I also met this issue on Mac using zsh.

[ifduyue]

On macOS using zsh.

[zijie0]

Revert to 6.4.0 solve the issue.

[spacewander]

Interesting, this command is expected to be executed under bash:

git-extras/bin/git-effort

Line 1 in 2d1aa6d

#!/usr/bin/env bash

What is the /usr/bin/env bash --version output in your machine?

[zijie0]

/usr/bin/env bash --version
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin21)
Copyright (C) 2007 Free Software Foundation, Inc.

I also tried switching to bash:

bash

The default interactive shell is now zsh.
To update your account to use zsh, please run `chsh -s /bin/zsh`.
For more details, please visit https://support.apple.com/kb/HT208050.
bash-3.2$ echo $SHELL
/bin/zsh

I think there's some setting need to be modified on Mac?

[ifduyue]

Maybe another way to achieve the same purpose? How about jobs -r | wc -l?

[ifduyue]

After brew install bash git-effort works again.

[spacewander]

Maybe another way to achieve the same purpose? How about jobs -r | wc -l?

Pull request is welcome!

[spacewander]

@ifduyue @zijie0
Here is an interesting question: as we have #!/usr/bin/env bash in every script, why zsh is used instead?

[ifduyue]

@spacewander Mac OS bundled /bin/bash version is GNU bash, version 3.2.57(1)-release (arm64-apple-darwin21), it's too low that it doesn't support ${parameter@P}.

[chipweinberger]

I'm getting this error too!

M1 MBP.

git version 2.32.0 (Apple Git-132)

git extras -v
6.5.0

MacOS 12.6.3

Edit, yes after brew install bash git-effort works again.