Skip to content

delete minor unreachable code caused by t.Fatal #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
or-else merged 1 commit into from
Aug 8, 2022
Merged

delete minor unreachable code caused by t.Fatal #781

or-else merged 1 commit into from
Aug 8, 2022

Conversation

@Abirdcfly
Copy link
Contributor

@Abirdcfly Abirdcfly commented Aug 8, 2022

Signed-off-by: Abirdcfly [email protected]

https://pkg.go.dev/testing#T.Fatal

Fatal is equivalent to Log followed by FailNow.

so break will not run.

@Abirdcfly Abirdcfly mentioned this pull request Aug 8, 2022
Closed
@or-else or-else merged commit 636e185 into tinode:next Aug 8, 2022
@or-else
Copy link
Contributor

or-else commented Aug 8, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Abirdcfly @or-else