Skip to content

copr: vectorize weekofyear #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sre-bot merged 10 commits into from
Dec 9, 2019
Merged

copr: vectorize weekofyear #5973

sre-bot merged 10 commits into from
Dec 9, 2019

Conversation

@AerysNan
Copy link
Contributor

@AerysNan AerysNan commented Nov 20, 2019

Signed-off-by: AerysNan [email protected]

PCP #5751

What have you changed?

Vectorize weekofyear.

What is the type of the changes?

Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No.

Does this PR affect tidb-ansible?

No.

@AerysNan
vectorize weekofyear
cfc5138 
Signed-off-by: AerysNan <[email protected]>
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 20, 2019
@AerysNan
Copy link
Contributor Author

AerysNan commented Nov 20, 2019

@sre-bot /run-integration-copr-test copr-test=pr/61

@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

/run-integration-copr-test copr-test=pr/61

@AerysNan
Copy link
Contributor Author

AerysNan commented Nov 21, 2019

@sre-bot /run-integration-copr-test copr-test=pr/61

@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

/run-integration-copr-test copr-test=pr/61

breezewish
breezewish previously approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iosmanthus PTAL

@breezewish breezewish added sig/coprocessor SIG: Coprocessor status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2019
@AerysNan
Copy link
Contributor Author

AerysNan commented Nov 25, 2019

@sre-bot /run-integration-copr-test copr-test=pr/61

@sre-bot
Copy link
Contributor

sre-bot commented Nov 25, 2019

/run-integration-copr-test copr-test=pr/61

iosmanthus
iosmanthus reviewed Nov 25, 2019
View reviewed changes
@AerysNan
Copy link
Contributor Author

AerysNan commented Nov 25, 2019

@sre-bot /run-integration-copr-test copr-test=pr/61

@sre-bot
Copy link
Contributor

sre-bot commented Nov 25, 2019

/run-integration-copr-test copr-test=pr/61

@AerysNan AerysNan requested a review from iosmanthus November 25, 2019 14:26
@AerysNan
update
9ab2e8e 
Signed-off-by: AerysNan <[email protected]>
breezewish
breezewish previously approved these changes Nov 27, 2019
View reviewed changes
@AerysNan AerysNan requested a review from breezewish November 27, 2019 03:59
@AerysNan AerysNan closed this Nov 27, 2019
@AerysNan AerysNan deleted the vectorize/weekofyear branch November 27, 2019 04:00
@AerysNan AerysNan restored the vectorize/weekofyear branch November 27, 2019 04:10
@AerysNan AerysNan reopened this Nov 27, 2019
@TennyZhuang
Copy link
Contributor

TennyZhuang commented Dec 3, 2019

/approve

sre-bot
sre-bot previously approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@sre-bot sre-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iosmanthus
iosmanthus previously approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@iosmanthus iosmanthus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iosmanthus
Copy link
Member

iosmanthus commented Dec 3, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 3, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

@AerysNan merge failed.

@breezewish breezewish added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 4, 2019
@breezewish
Copy link
Member

breezewish commented Dec 8, 2019

Sorry again :) Please fix conflicts. Our tests should work now!

@breezewish breezewish mentioned this pull request Dec 8, 2019
Open
@AerysNan AerysNan dismissed stale reviews from iosmanthus and sre-bot via 67d8511 December 9, 2019 02:11
@TennyZhuang
Copy link
Contributor

TennyZhuang commented Dec 9, 2019

/approve

sre-bot
sre-bot approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@sre-bot sre-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

breezewish
breezewish approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@breezewish
Copy link
Member

breezewish commented Dec 9, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 9, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 9, 2019

@AerysNan merge failed.

@breezewish
Copy link
Member

breezewish commented Dec 9, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 9, 2019

/run-all-tests

@sre-bot sre-bot merged commit 38579ea into tikv:master Dec 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 9, 2019

@AerysNan complete task #5751 and get 50 score, currerent score 750.

@sre-bot
Copy link
Contributor

sre-bot commented Dec 9, 2019

Congratulations, you get 750 score from easy level tasks in PCP-S1, and if your PRs in reviewed stage all got merged, the score will be 950, try some medium and hard tasks!(you can not reward from easy and vector tasks now)

c1ay pushed a commit to c1ay/tikv that referenced this pull request May 9, 2020
@AerysNan @c1ay
copr: vectorize weekofyear (tikv#5973)
cb06de3 
Signed-off-by: AerysNan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TennyZhuang TennyZhuang TennyZhuang left review comments

@breezewish breezewish breezewish approved these changes

@sre-bot sre-bot sre-bot approved these changes

@iosmanthus iosmanthus iosmanthus left review comments

Assignees

@breezewish breezewish

@TennyZhuang TennyZhuang

@iosmanthus iosmanthus

Labels

contribution This PR is from a community contributor. sig/coprocessor SIG: Coprocessor status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AerysNan @sre-bot @TennyZhuang @iosmanthus @breezewish