Skip to content

Guard against old discrete scales with identity palettes #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Guard against old discrete scales with identity palettes #5933

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8031a33
rescue old palettes
teunbrand Jun 5, 2024
34f8a27
Revert "rescue old palettes"
teunbrand Jul 8, 2024
098ab30
rescue in construction
teunbrand Jul 8, 2024
7436002
fix typo
teunbrand Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions R/scale-discrete-.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ ScaleDiscretePosition <- ggproto("ScaleDiscretePosition", ScaleDiscrete,

map = function(self, x, limits = self$get_limits()) {
if (is.discrete(x)) {
# Guard against old use of having identity palettes
if (identical(.subset2(self, "palette"), identity)) {
self$palette <- seq_len
}
values <- self$palette(length(limits))
if (!is.numeric(values)) {
cli::cli_abort(
Expand Down