Skip to content

nate/fix/LOOP-1927/manual-glucose-entry #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhamming merged 8 commits into from
Sep 22, 2020
Merged

nate/fix/LOOP-1927/manual-glucose-entry #244

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d000014
require the CGM manager to interpret glucose sample using its managed…
nhamming Sep 18, 2020
2c02823
added signal loss to Mock CGM manager
nhamming Sep 21, 2020
e084c55
Merge branch 'dev' into nate/fix/LOOP-1927/manual-glucose-entry
nhamming Sep 21, 2020
2c3e562
Merge branch 'dev' into nate/fix/LOOP-1927/manual-glucose-entry
nhamming Sep 21, 2020
f9079c6
correct the restore of the CGM sim signal loss data model
nhamming Sep 22, 2020
14d31e8
added default implementation for categorizing glucose range
nhamming Sep 22, 2020
90beeee
restore signal loss status highlight while in signal loss model
nhamming Sep 22, 2020
286face
Merge branch 'dev' into nate/fix/LOOP-1927/manual-glucose-entry
nhamming Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions LoopKitUI/CGMManagerUI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ public protocol CGMManagerUI: CGMManager, DeviceManagerUI {

/// the completed percent of the progress bar to display in the status bar
var cgmLifecycleProgress: DeviceLifecycleProgress? { get }

/// gets the type of a glucose sample using the CGM manager managed glucose thresholds
func glucoseValueType(for glucose: GlucoseSampleValue) -> GlucoseValueType?
Copy link

@ps2 ps2 Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ValueType" is quite vague. Looking at what GlucoseValueType contains, maybe GlucoseRangeCategory?

}

public protocol CGMManagerSetupViewController {
Expand Down