Skip to content

Conversation

@elena-io
Copy link

Hi there!

As per the requirement, the SEPTA fare calculator has been built.

Quick overview:

  • used React
  • made a couple assumptions and added comment in the code accordingly
  • didn't bring in any css framework or libraries

Space for improvement:

  • css - would refactor scc and have a dedicated css file for each component
  • address all the @debt comments in the code
  • define failure user flow, if something is not working or the api is failing, there should be an error scenario, currently only happy path is accounted for
  • make it pixel perfect, for now styled it so it's not bad to look at
  • unit tests

Please enjoy the final product and a quick demo below.

septa-fare-calculator-demo.mov

Thanks for your time.

Elena

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant