fix for createDirectory when prefix is used #1554
Closed
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a prefix is used the createDirectory is incorrect. What is going wrong: line 212: The parts are first retrieved including the prefix line 224: The $directoryPath included the prefix. But the function 'directoryExists' will also put the prefix in front.
Member
|
Thank you for raising the issue. I've fixed the issue a little bit different because the proposed solution doesn't create the root directory. Let me know if the fix works for you :) |
Member
|
The fix is released as 3.5.1, thanks again for reporting and providing a description of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a prefix is used the createDirectory is incorrect. What is going wrong:
line 212: The parts are first retrieved including the prefix
line 224: The $directoryPath included the prefix. But the function 'directoryExists' will also put the prefix in front. So check is performed with 2 times the prefix in the path