chore(main): [bot] release t8s-cluster:9.5.0 #1760
Conversation
teutonet-bot
requested review from
a team,
marvinWolff and
tasches
as code owners
WalkthroughBumps the t8s-cluster Helm chart from 9.4.1 to 9.5.0 by updating the release manifest and Chart.yaml, and adds a 9.5.0 changelog entry documenting new features, bug fixes, and dependency updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/t8s-cluster/Chart.yaml (1)
18-18: Update source reference to reflect new chart version.Line 18 still references the old tag
t8s-cluster-v9.4.1in the sources URL. For consistency and accurate documentation, this should be updated tot8s-cluster-v9.5.0.Apply this diff to update the source reference:
- - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.4.1/charts/t8s-cluster + - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.5.0/charts/t8s-cluster
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/release-please/manifest.json(1 hunks)charts/t8s-cluster/CHANGELOG.md(1 hunks)charts/t8s-cluster/Chart.yaml(1 hunks)
🔇 Additional comments (3)
.github/release-please/manifest.json (1)
1-1: Version bump correctly reflected in manifest.The t8s-cluster chart version is correctly updated from 9.4.1 to 9.5.0, with all other chart versions unchanged. This aligns with the release intent.
charts/t8s-cluster/Chart.yaml (1)
21-21: Chart version bump to 9.5.0 looks good.The version field is correctly updated to match the release.
charts/t8s-cluster/CHANGELOG.md (1)
3-9: Changelog entry for 9.5.0 is well-formed and accurate.The new release section is correctly formatted, dated (2025-10-22), and documents the cluster-autoscaler deployment feature with appropriate issue and commit references. The previous 9.4.1 entry is properly preserved below.
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
3 times, most recently
from
cb14028 to
7bfa269
Compare
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
7 times, most recently
from
1d50226 to
ea17e2f
Compare
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
from
74567e5 to
96a8482
Compare
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
from
68507b0 to
fc00ee6
Compare
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
3 times, most recently
from
9755f48 to
1eb90c7
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/t8s-cluster/Chart.yaml (1)
18-18: Consider updating the source URL to reference the new release tag.The sources field on line 18 still references the old
v9.4.1release tag, while the chart version has been bumped to9.5.0. Consider updating this tot8s-cluster-v9.5.0to keep the reference current and consistent with the chart version. Line 19's reference tomainis also appropriate and remains current.Apply this diff to align the source URL with the new version:
- - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.4.1/charts/t8s-cluster + - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.5.0/charts/t8s-cluster
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/release-please/manifest.json(1 hunks)charts/t8s-cluster/CHANGELOG.md(1 hunks)charts/t8s-cluster/Chart.yaml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- .github/release-please/manifest.json
- charts/t8s-cluster/CHANGELOG.md
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
📚 Learning: 2025-07-24T09:41:28.072Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Applied to files:
charts/t8s-cluster/Chart.yaml
📚 Learning: 2025-07-24T09:49:40.961Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
Applied to files:
charts/t8s-cluster/Chart.yaml
📚 Learning: 2025-07-24T09:41:28.072Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Applied to files:
charts/t8s-cluster/Chart.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: lint helm chart (t8s-cluster)
🔇 Additional comments (1)
charts/t8s-cluster/Chart.yaml (1)
21-21: Version bump looks correct.The version field correctly updates from 9.4.1 to 9.5.0, matching the release notes and PR objectives.
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
3 times, most recently
from
49eee75 to
24563d3
Compare
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
2 times, most recently
from
92c97ce to
1276bb7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
charts/t8s-cluster/README.md (1)
426-433: Confirm breaking change risk for additionalSecurityGroupRules.remoteGroupID.The schema explicitly marks
remoteGroupIDas required in theadditionalSecurityGroupRules.additionalPropertiesobject, and the template enforces this with arequiredfilter. While all provided examples include this field, any existing cluster configuration with custom security group rules lackingremoteGroupIDwill fail schema validation and template rendering on upgrade. The README change documents an already-enforced requirement; verify that:
- CHANGELOG includes migration guidance for users with existing
additionalSecurityGroupRulesconfigurations- Whether this requirement is newly introduced in this PR or was pre-existing
Also applies to: 498-504
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/release-please/manifest.json(1 hunks)charts/t8s-cluster/CHANGELOG.md(1 hunks)charts/t8s-cluster/Chart.yaml(1 hunks)charts/t8s-cluster/README.md(4 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- charts/t8s-cluster/CHANGELOG.md
- .github/release-please/manifest.json
- charts/t8s-cluster/Chart.yaml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-24T09:56:41.380Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.
Applied to files:
charts/t8s-cluster/README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: lint helm chart (t8s-cluster)
🔇 Additional comments (1)
charts/t8s-cluster/README.md (1)
282-297: The review comment appears to be based on a misinterpretation of the README table formatting.The actual schema state contradicts the claim of field removal:
- values.schema.json: All seven metadata properties (serviceLevelAgreement, customerID, customerName, friendlyName, supportProjectUrl, configGroupUrl, remarks) are still defined in the schema with only
serviceLevelAgreementmarked as required.- Templates: Charts still actively reference customerID (line 8, 15), customerName (line 16), supportProjectUrl (line 12), configGroupUrl (line 13), friendlyName (line 17), and remarks (line 13).
- CHANGELOG: Version 9.5.0 lists only features (autoscaler, ImageVolume, hcp switch) with no breaking changes or field removals documented.
The +/− table markers in the README do not indicate field removal. The fields remain optional properties in the schema and continue to be used by templates. There is no breaking change, no validation failures for existing configurations, and no migration guidance is needed.
The review comment should be disregarded.
Likely an incorrect or invalid review comment.
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
10 times, most recently
from
cca9ab9 to
95a9450
Compare
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
8 times, most recently
from
2897eed to
680fb11
Compare
teutonet-bot
force-pushed
the
release-please--branches--main--components--t8s-cluster
branch
from
680fb11 to
cd7790d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/release-please/manifest.json(1 hunks)charts/t8s-cluster/CHANGELOG.md(1 hunks)charts/t8s-cluster/Chart.yaml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/release-please/manifest.json
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-07-24T09:41:28.072Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Applied to files:
charts/t8s-cluster/Chart.yaml
📚 Learning: 2025-07-24T09:49:40.961Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1602
File: charts/base-cluster/templates/monitoring/kube-prometheus-stack/oauth-proxy.yaml:38-40
Timestamp: 2025-07-24T09:49:40.961Z
Learning: Official Helm charts like oauth2-proxy manage image versioning automatically through their Chart.yaml appVersion field, making manual tag pinning in consumer values unnecessary and potentially harmful. The chart version itself provides reproducibility by ensuring the correct image tag is used.
Applied to files:
charts/t8s-cluster/Chart.yaml
📚 Learning: 2025-07-24T09:41:28.072Z
Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The kubernetes-sigs/metrics-server Helm chart uses `v{{ .Chart.AppVersion }}` as the default image tag when `image.tag` is empty, which provides pinned versioning through the chart's AppVersion rather than using floating tags like "latest".
Applied to files:
charts/t8s-cluster/Chart.yaml
🪛 GitHub Actions: Lint Helm Charts
charts/t8s-cluster/Chart.yaml
[error] 1-1: Chart linting failed. 1 chart(s) linted, 1 chart(s) failed.
charts/t8s-cluster/CHANGELOG.md
[error] 1-1: Chart linting failed. 1 chart(s) linted, 1 chart(s) failed.
🔇 Additional comments (1)
charts/t8s-cluster/CHANGELOG.md (1)
3-31: LGTM! Comprehensive and well-structured changelog entry.The 9.5.0 changelog entry is complete and well-formatted with proper issue references, commit hashes, and clear categorization of features, bug fixes, and chores. The documented changes align well with the PR objectives, including the autoscaler namespace fix (issue #1877), CAPI v1beta2 migration, and dependency updates. All entries follow the conventional commit format expected by release-please tooling.
| name: tasches | ||
| name: t8s-cluster | ||
| sources: | ||
| - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.4.1/charts/t8s-cluster |
There was a problem hiding this comment.
Update stale source URL reference to the new version.
Line 18 references the old release tag t8s-cluster-v9.4.1 but the chart version has been bumped to 9.5.0. This stale reference may be contributing to the chart linting failure. Update the source URL to match the new version.
Apply this diff to fix the stale source URL:
- - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.4.1/charts/t8s-cluster
+ - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.5.0/charts/t8s-cluster📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.4.1/charts/t8s-cluster | |
| - https://github.com/teutonet/teutonet-helm-charts/tree/t8s-cluster-v9.5.0/charts/t8s-cluster |
🤖 Prompt for AI Agents
In charts/t8s-cluster/Chart.yaml around line 18 the source URL still points to
the old tag `t8s-cluster-v9.4.1`; update that URL to reference the chart's
current version (e.g. replace `t8s-cluster-v9.4.1` with `t8s-cluster-v9.5.0`) so
the source matches the bumped chart version and resolves the linting failure.
🤖 I have created a release beep boop
9.5.0 (2025-12-11)
Features
Bug Fixes
nil(#1837) (f370dac)Miscellaneous Chores
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
New Features
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.