Skip to content

feat: add 'accessors' option #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2022
Merged

feat: add 'accessors' option #197

merged 3 commits into from
Jul 13, 2022

Conversation

yanick
Copy link
Collaborator

@yanick yanick commented Jun 3, 2022

I need to clean this, but that should be the answer for #196

@yanick yanick changed the title add 'accessors' option feat: add 'accessors' option Jun 3, 2022
@yanick
Copy link
Collaborator Author

yanick commented Jun 4, 2022

Okay, it's now clean and, I think, ready to go.

@sebastianrothe
Copy link
Collaborator

What is missing here? How can we get "Semantic Pull Request" to be green?

@yanick
Copy link
Collaborator Author

yanick commented Jul 13, 2022

What is missing here? How can we get "Semantic Pull Request" to be green?

The Semantic Pull action is controlled by a project that is no longer active / working, so I don't think there is anything we (we = anybody but the true owner of the repo) can do to fix it.

BUUUUT I do have magic admin powers to at least merge the PR. I'll do so. :-)

@yanick yanick merged commit e168c19 into main Jul 13, 2022
@sebastianrothe
Copy link
Collaborator

What is missing here? How can we get "Semantic Pull Request" to be green?

The Semantic Pull action is controlled by a project that is no longer active / working, so I don't think there is anything we (we = anybody but the true owner of the repo) can do to fix it.

BUUUUT I do have magic admin powers to at least merge the PR. I'll do so. :-)

Okay, because I could not find any errors.

@WbaN314
Copy link

WbaN314 commented Aug 13, 2022

This fix is not yet included in the latest version of the node package. Shouldn't the version be updated to 3.1.4 or am i misunderstanding?

@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yanick
Copy link
Collaborator Author

yanick commented Aug 19, 2022

It seems that merging another PR did the trick and kicked the deployment process into gears. W00t! 🎉

@mcous mcous deleted the accessors branch June 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants