Skip to content

Revisit the type changes #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yanick opened this issue Jun 4, 2022 · 1 comment · Fixed by #298
Closed

Revisit the type changes #199

yanick opened this issue Jun 4, 2022 · 1 comment · Fixed by #298
Labels
released on @next

Comments

@yanick
Copy link
Collaborator

yanick commented Jun 4, 2022

We should revisit the type changes reverted in #198 Mostly, we should have some typescript tests to make sure those new types are not breaking anything.

Related to #195
@mcous mcous mentioned this issue Jan 29, 2024
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add simple typing tests
1 participant
@yanick