Skip to content

support context options? #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cbbfcd opened this issue Apr 28, 2021 · 2 comments
Closed

support context options? #136

cbbfcd opened this issue Apr 28, 2021 · 2 comments

Comments

@cbbfcd
Copy link

cbbfcd commented Apr 28, 2021

hi 👋

as the svelte doc.

I haven't paid attention to the progress of the release about svelte, but it seems that context configuration is already supported.

const svleteComponentOptions = ['anchor', 'props', 'hydrate', 'intro'] // add 'context' ?
@apricote apricote mentioned this issue Jun 11, 2021
Closed
@cbxp
Copy link

cbxp commented Sep 21, 2021

Yes, please allow context. It's a simple change that will make testing with context much easier.

paul-schwendenman added a commit to paul-schwendenman/newsfeed-app that referenced this issue Nov 30, 2021
@paul-schwendenman
Skip test because testing library doesn't allow passing contexts duri…
b0ca51a 
…ng render

testing-library/svelte-testing-library#136
yanick added a commit to yanick/svelte-testing-library that referenced this issue Jan 24, 2022
@yanick
feat: add context to the allowed options
45bdbe1 
For testing-library#136

Allows 'context' as one of the Svelte options.

Note that most of the changes are due to prettier and husky.
@yanick yanick mentioned this issue Jan 24, 2022
Merged
@yanick
Copy link
Collaborator

yanick commented Mar 15, 2022

The feature has been merged in, so closing issue.

@yanick yanick closed this as completed Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: set svelte context in render fn
3 participants
@yanick @cbxp @cbbfcd