Skip to content

Conversation

@joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented Dec 2, 2025

Closes #1191

Migration Guide: https://docs.confluent.io/kafka-clients/javascript/current/migration.html

I used the following commands to update the packages and lock:

nvm use 24
npm install -g npm@latest
npm install
npm audit fix
cd packages/modules/kafka
npm install -D @confluentinc/kafka-javascript
npm uninstall kafkajs
cd ../redpanda
npm install -D @confluentinc/kafka-javascript
npm uninstall kafkajs

Notes:

# npm audit report

jws  =4.0.0 || <3.2.3
Severity: high
auth0/node-jws Improperly Verifies HMAC Signature
https://github.com/advisories/GHSA-869p-cjfg-cm3x
fix available via `npm audit fix`
node_modules/jsonwebtoken/node_modules/jws
node_modules/jws

@netlify
Copy link

netlify bot commented Dec 2, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit b937757
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/69369e4ebbdf5c0008f214b0
😎 Deploy Preview https://deploy-preview-1192--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@joebowbeer joebowbeer force-pushed the joebowbeer-confluent-kafka branch from 8d88f6b to 517c17d Compare December 2, 2025 08:39
@cristianrgreco cristianrgreco added the maintenance Improvements that do not change functionality label Dec 2, 2025
@joebowbeer joebowbeer marked this pull request as draft December 2, 2025 14:38
@joebowbeer

This comment was marked as resolved.

@joebowbeer joebowbeer force-pushed the joebowbeer-confluent-kafka branch from cc0d0cb to 7cc6c75 Compare December 3, 2025 05:53
@joebowbeer

This comment was marked as resolved.

@joebowbeer joebowbeer marked this pull request as ready for review December 3, 2025 06:13
@joebowbeer

This comment was marked as resolved.

@joebowbeer joebowbeer force-pushed the joebowbeer-confluent-kafka branch from 7cc6c75 to c043180 Compare December 8, 2025 07:24
@joebowbeer joebowbeer force-pushed the joebowbeer-confluent-kafka branch from c043180 to b937757 Compare December 8, 2025 09:45
@joebowbeer
Copy link
Contributor Author

joebowbeer commented Dec 8, 2025

@cristianrgreco I addressed the three SASL_SSL test errors

This is ready to merge.

Btw, one of the unmodified tests fails for me locally in Rancher Desktop on Apple Silicon, as noted

This is because there's no arm64 image for the requested zookeeper image.

@cristianrgreco
Copy link
Collaborator

Thanks @joebowbeer! I'm a bit swamped at the moment, will look at it soon

@cristianrgreco cristianrgreco changed the title chore: migrate kafkajs to @confluentinc/kafka-javascript Migrate kafkajs to @confluentinc/kafka-javascript Dec 9, 2025
@cristianrgreco cristianrgreco merged commit 4c25cd1 into testcontainers:main Dec 9, 2025
332 checks passed
@joebowbeer joebowbeer deleted the joebowbeer-confluent-kafka branch December 9, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Improvements that do not change functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use maintained Kafka client in KafkaContainer tests

2 participants