Skip to content

Conversation

@technocidal
Copy link
Contributor

@technocidal technocidal commented Jul 8, 2025

Relates to #556.

Follows the commonly known Docker format for specifying ports with a protocol. Backwards compatibility has been tested. If no protocol is specified, it'll default to tcp which is all that was possible with testcontainers-node up until now anyway.

@netlify
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 421f6ab
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/68891c3977f6ba00088d7b10
😎 Deploy Preview https://deploy-preview-1068--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Jul 8, 2025
@technocidal
Copy link
Contributor Author

@cristianrgreco I'll hopefully get this into a publishable state very soon. It's currently logging way too much and some stuff needs cleaning up. I'm however using this version already at my job (telephony/voice engineering where UDP is quite important) for integration testing and it works quite well! Thanks for your patience.

@cristianrgreco
Copy link
Collaborator

@technocidal No problem at all. Thanks for working on it! Let me know if if there's anything I can help with

@technocidal technocidal marked this pull request as ready for review July 23, 2025 22:19
@cristianrgreco
Copy link
Collaborator

Looks like there’s a compilation issue

@technocidal
Copy link
Contributor Author

Looks like there’s a compilation issue

Should be addressed in the latest commit

@cristianrgreco cristianrgreco merged commit 98a81b3 into testcontainers:main Aug 1, 2025
316 checks passed
@cristianrgreco
Copy link
Collaborator

cristianrgreco commented Aug 1, 2025

Thanks @technocidal for your contribution, and patience with reviewing the PR!

@technocidal
Copy link
Contributor Author

@cristianrgreco And thanks for your patience with all of my little mistakes and oversights and especially for your valuable feedback. Have a nice weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor Backward compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants