Sort list items to prevent order changes in domain lists #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
sort()
function to sort alternative domain list parameterMotivation and Context
Sometimes constructed lists change order of the list items when generated programmatically, which causes ACM cert to be re-requested, creating essentially the same cert with a different order.
This is an attempt to ensure this is not happening
This is merely a safeguard for users, which ensures better default behavior. If the current stance of the module is that a user should take care of it, that's fine too, so feel free to reject it. Thanks!
Breaking Changes
No breaking changes expected.
How Has This Been Tested?
Used
sort()
in front of module parameter, when passed to a module.