Skip to content

Sort list items to prevent order changes in domain lists #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DimmKirr
Copy link

Description

Added sort() function to sort alternative domain list parameter

Motivation and Context

Sometimes constructed lists change order of the list items when generated programmatically, which causes ACM cert to be re-requested, creating essentially the same cert with a different order.
This is an attempt to ensure this is not happening

This is merely a safeguard for users, which ensures better default behavior. If the current stance of the module is that a user should take care of it, that's fine too, so feel free to reject it. Thanks!

Breaking Changes

No breaking changes expected.

How Has This Been Tested?

Used sort() in front of module parameter, when passed to a module.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant