Skip to content

Build on arm64 with github action #4571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

hannesa2
Copy link
Contributor

@hannesa2 hannesa2 commented May 30, 2025

If points out build issues on MacOS arm64 #4569

@hannesa2 hannesa2 mentioned this pull request May 30, 2025
@agnostic-apollo agnostic-apollo force-pushed the BuildArm64 branch 9 times, most recently from e59dfeb to d435ee2 Compare May 30, 2025 14:42
@agnostic-apollo
Copy link
Member

Builds fine for macos-15 just by using ndkVersion=27.1.12297006 and jdk-17, you had not rebased this branch against master branch for 9d2ac14 fix, likely haven't done that locally too for #4569 if you are still seeing the same error.

@agnostic-apollo
Copy link
Member

I had already pushed commits to fix the runner environment to build. macos-14 doesn't have sha256sum, that's why I also deleted it after testing build works in it too, no specific need to test it, as not an issue with termux app build config, but runner environment.

Also FYI, this pull won't be merged, at least until I push to master as workflow file doesn't even exist locally and no immediate need to test macos builds. Will have to disable artifact upload for it too if it were added to prevent duplicate artifacts to be uploaded for each os.

@hannesa2
Copy link
Contributor Author

hannesa2 commented Jun 3, 2025

and no immediate need to test macos builds

There is a need !
Btw, the over engineered and error prone versionName doesn't work on MacOS.
Why not simply use git describe --tags like this

@agnostic-apollo
Copy link
Member

Firstly, commit hashes are only added for github action builds, and not normal local or release builds. And users build locally as well with specific versioning schemes, so need to support that.

Secondly, fdroid requires hardcoded values.

0aa5a12

Thirdly, it does work on macos 14 and 15 as I already tested in the workflow run referred above as per workflow file in https://github.com/termux/termux-app/blob/d435ee2fdc58e1c6554657ead2c72fc315cb9275/.github/workflows/debug_build.yml. You overwrote my commits, I can push them again if that's what you want.

@hannesa2
Copy link
Contributor Author

hannesa2 commented Jun 4, 2025

Don't worry, I just want to see, if d435ee2 works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants