-
Notifications
You must be signed in to change notification settings - Fork 214
activations, constraints, initializers, losses, regularizers: move Ops param from CTOR to call method #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sync with master tensorflow on upstream
Merge main branch to local branch
Update after losses merge
Fix Javadoc errors (tensorflow#152)
pull type def
Metrics Phase 1 (tensorflow#180)
Pull latest tensorflow master
Merge with latest
Resync with origin/master
Sync with tensorflow/java master
Sync with Metrics Phase 2
Sync with master
Sync with Regularizers
Will merge after #331, if the quick-build passes. |
@JimClarke5 , can you rebase your PR so that we can validate now that the quick-build is passing? |
@karllessard I think I have rebased it. Give it a try. |
It failed again, looks like it’s the javadoc trouble that is back :-|
Wait, I think I'm confusing things... I'll try to demystify that later |
I see that you merged master to your branch, I don’t think that’s the issue but rebasing is always better. You can drop your last commit (the merge one) and retry with |
Oh wait, in fact, these javadoc errors are real errors this time :) Can you please fix them and push a new version? |
@karllessard @rnett The "check format" is erroring on lines between imports. I ran |
The way to reformat now is to run |
@karllessard I did the |
This PR moves the
Ops
parameter out of the classCTOR
s into their respectivecall
methods. Also, an interface was created for each package for the respectivecall
method. These packages were chosen because they are stateless wrt the Graph (e.g. noVariables
).There is no change in functionality of these classes, just the move of the
Ops
parameter tocall
.This is related to issue: #327