[WIP] feat(workflow): Add support for failing workflow execution on some error types #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add support for failing workflow execution on some error types, notably Non-Determinism errors. Resolves #1358.
TODO
Add support to catch other error types (aside of NDE) on the lang-side Workflow Worker.
Q: Where should that be done? In sandbox? Worker thread? or main thread worker? Formers will make that visible to interceptors, later will ensure we can catch codec errors and some rare runtime errors.
A: Other SDKs do this on the workflow side, same place where it checks if thrown error is a cancellation or TemporalFailure.
Add API to define error types in workflow (ie. in addition to WorkerOptions). That will ensure possibility of catching on subclasses, which can't be on through error type names.
Add tests