-
Notifications
You must be signed in to change notification settings - Fork 128
User metadata #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
THardy98
wants to merge
17
commits into
main
Choose a base branch
from
user-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
User metadata #1657
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7b3aa1c
init impl of user metadata
THardy98 2dab40d
add test, removed proxyActivities overloads instead added withSummari…
THardy98 6af2e2c
schedule metadata test, fix schedule action decode
THardy98 e0489cd
Merge branch 'main' into user-metadata
THardy98 031e295
test fix
THardy98 d496966
use supplied data converter
THardy98 1efb3f0
inline options, lazily decode summary/details on workflow description
THardy98 ebe745f
update proxyActivities comment to show runWithOptions usage
THardy98 2c8f922
Merge branch 'main' into user-metadata
THardy98 67d8e06
add runWithOptions for local activities
THardy98 c491683
allow for undefined userMetadata when scheduling activity
THardy98 60a1e08
move user metadata encoding/decoding to user-metadata.ts, add deepMer…
THardy98 3cfffa7
break circular dependency
THardy98 e56a117
add codec testing
THardy98 421e080
remove redundant 'fixed'
THardy98 f2bd7d3
lint.prune fix
THardy98 af1e8bb
Merge branch 'main' into user-metadata
THardy98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -124,6 +124,14 @@ export interface ActivityOptions { | |
*/ | ||
versioningIntent?: VersioningIntent; | ||
|
||
/** | ||
* A single-line fixed summary for this workflow execution that may appear in the UI/CLI. | ||
* This can be in single-line Temporal markdown format. | ||
* | ||
* @experimental User metadata is a new API and suspectible to change. | ||
*/ | ||
staticSummary?: string; | ||
|
||
/** | ||
* Priority of this activity | ||
*/ | ||
|
@@ -192,4 +200,12 @@ export interface LocalActivityOptions { | |
* - `ABANDON` - Do not request cancellation of the activity and immediately report cancellation to the workflow. | ||
*/ | ||
cancellationType?: ActivityCancellationType; | ||
|
||
/** | ||
* A single-line fixed summary for this workflow execution that may appear in the UI/CLI. | ||
* This can be in single-line Temporal markdown format. | ||
* | ||
* @experimental User metadata is a new API and suspectible to change. | ||
*/ | ||
staticSummary?: string; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no |
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should be only
summary
, nostatic
. What's the terminology in other SDKs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a bit of a mix, but generally
static
prefix for workflow start methods, otherwise nostatic
, i'ved opted for the same