Add --tds-version flag to CLI #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensby
requested changes
Oct 24, 2025
Collaborator
dhensby
left a comment
dhensby
left a comment
There was a problem hiding this comment.
I think that the changes bin/mssql:65 and lib/tedious/connection-pool.js:16-17 are not required.
The other changes are fine and look good.
Collaborator
|
The linter doesn't like the trailing commas :( |
dhensby
requested changes
Oct 27, 2025
Update lib/tedious/connection-pool.js Co-authored-by: Daniel Hensby <[email protected]>
luisvinicius09
force-pushed
the
master
branch
from
a7ed5d5 to
b760d4f
Compare
Contributor
Author
|
I've had approved a commit from GitHub UI and it come out not following the convention - I've squashed the changes into the previous commit, because it seemed fit. Sorry for the back and forth, let me know if anymore changes are needed. |
Collaborator
|
Thank you; sorry I meant to also reword the commit for you, but I've been snowed under recently and hadn't got round to it. I think it'll go green now 👍 |
dhensby
approved these changes
Nov 4, 2025
|
🎉 This PR is included in version 12.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does:
Adds support for specifying the TDS protocol version when connecting to SQL Server.
Includes a new CLI option --tds-version and propagates it through configuration and connection pooling logic.
Related issues:
#1781 - Missing tdsVersion option on CLI
Pre/Post merge checklist: