Add tests for invalid calendar ids, include unknown calendar id. #4797
+929
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Found some mistakes, converting to draft while I fix them. |
Also homogenise format of existing tests, adding the test for unknown calendar id u-ca=notacal. This addresses issue tc39#3896 Two tests (argument-string-* and argument-propertybag-* are added or addended for the following. Duration.(round, total)'s option relativeTo, Duration.compare's option relativeTo, PlainDate.prototype.(equals, since, until), PlainDate.(from, compare), PlainDateTime.prototype.(equals, since, until), PlainDateTime.(from, compare), PlainMonthDay.prototype.equals, PlainMonthDay.from, PlainYearMonth.prototype.(equals, since, until), PlainDate.(from, compare), ZonedDateTime.prototype.(equals, since, until), ZonedDateTime.(from, compare) The tests calendar-invalid-iso-string.js with string arguments are addended for each constructor and each withCalendar (these do not take argument bags).
ioannad
force-pushed
the
Temporal-unknown-calendar-tests
branch
from
d7217b7 to
7bedd62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also homogenise format of existing tests, adding the test for unknown calendar id u-ca=notacal.
This addresses issue #3896
Two tests (argument-string-* and argument-propertybag-* are added or addended
for the following.
The tests calendar-invalid-iso-string.js with string arguments are addended
for each constructor and each withCalendar (these do not take argument bags).