Fix roster role link in members, and remove role description top-level link in public.

[jefft]

Fixes #1330 and #1331 (changes are intedependent).

#1330 is a simple fix:

• make the roster role's hyperlink page-relative. I.e. change BASE_URL.'/public/?view=display_role_description... to ?view=_roster_role_description in roster_view.class.
• create a new view, members/views/view_0_roster_role_description.class.php, identical to public/ equivalent, for the now-relative hyperlink to point to.

#1331 is also a simple but messy business of renaming files and links.

The result:

[tbar0970]

I agree that role descriptions featuring in the main nav is more prominent than they need to be.
However experience indicates that many people don't notice the links in the roster column headers - it leaves the role decriptions a bit too hard to find.
How about: When you click "rosters" (formerly "Display roster") in the top nav, and get the list of available rosters, that page could also include some prominent link to "roster role descriptions"? Or: Since there are liklely only a handful of roster views to choose from, that list could be followed by a listing of roster roles, linked to their descriptions
?

[jefft]

I agree that role descriptions featuring in the main nav is more prominent than they need to be.
However experience indicates that many people don't notice the links in the roster column headers - it leaves the role decriptions a bit too hard to find.

Well, to step back a bit: I find it very weird that role descriptions are visible at all in the public/ section. Visible in /members - sure! but why /public?

Roster roles are internal church-running business. Content is often highly specific and usually not written for public consumption:

Is there some use-case for making roles public, or can we get rid of roster role descriptions from /public altogether?

How about: When you click "rosters" (formerly "Display roster") in the top nav, and get the list of available rosters, that page could also include some prominent link to "roster role descriptions"?

We could have a link:

Or: Since there are liklely only a handful of roster views to choose from, that list could be followed by a listing of roster roles, linked to their descriptions

Do you mean, like:

I think people might skim the page, see "Aha! The 4pm Band roster! Let's see who's on..", click, and be confused.

[tbar0970]

Is there some use-case for making roles public, or can we get rid of roster role descriptions from /public altogether?

Yes - the use case where the members area is disabled, or people aren't in the habit of using it. When people hit a login page they're not familiar with, x% of them give up. So my church uses public roster URLs, with the "public roster secret" setting to make it less world-findable.

Do you mean, like:

Yes, that last example is what I had in mind (with subtitle "roster role descriptions"). But the single link would also be OK.

[tbar0970]

I chuckled when I just came across this: #1217

[jefft]

Replaced by PR #1346