Consistent use of relative URLs, and make BASE_URL optional #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefft
force-pushed
the
push-relative-urls
branch
from
954d6fc to
b4ab1cf
Compare
jefft
force-pushed
the
push-relative-urls
branch
from
b4ab1cf to
ec107e8
Compare
jefft
force-pushed
the
push-relative-urls
branch
2 times, most recently
from
b94b9d5 to
1778611
Compare
Owner
|
Related: #93 |
well as absolute, and allows relative BASE_URLs.
URLs were not possible. Don't break if BASE_URL doesn't end in a slash.
…-relative, and Jethro will run wherever it finds itself.
jefft
force-pushed
the
push-relative-urls
branch
from
1778611 to
e15be86
Compare
Contributor
Author
|
Replaced by #1351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jethro is full of
href=andsrc=URL references, and is not too consistent in their use:href="?call=..."href="/?view=...". These won't work if there is a URL path prefix e.g./demoin https://easyjethro.com.au/demohref="<?php echo BASE_URL; ?>/?view=..."This patch gets things more consistent by:
<?php echo BASE_URL; ?>everywhere./resources,/publicand/membersURLs.By getting things consistent, it's actually possible to omit
BASE_URLaltogether, or set it to''or'/demo'. This was my original goal: I want Jethro to run wherever it finds itself. If my Jethro normally runs at https://jethro.mychurch.com, by setting BASE_URL='' I can run it at http://localhost/mychurch without changing anything.