Catch duplicate labels in general configuration #1313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefft
force-pushed
the
push-1305-errorhandling-catch-duplicate-labels-in-general-config
branch
from
cb6f72c to
0b27ec4
Compare
jefft
force-pushed
the
push-1305-errorhandling-catch-duplicate-labels-in-general-config
branch
2 times, most recently
from
fc960b8 to
b63dfa7
Compare
scrolling to the part of the page with the error.
Javascript validation that a set of fields have no duplicate text. Used in the general configuration page. Fixes #1305
jefft
force-pushed
the
push-1305-errorhandling-catch-duplicate-labels-in-general-config
branch
from
b63dfa7 to
6b872b1
Compare
Contributor
Author
|
Replaced by #1350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1305.
This PR builds upon / incorporates #1312. I don't know how to make Github show only f24004d, which is the only distinct commit not from #1312.
Jethro needs to detect duplicates in some fields on the general configuration page, namely:
This PR prevents submission of duplicates:
Screencast_20250917_220124.webm
In terms of code, I've introduced a
required-noduplicatesclass, which may be applied to thetbodyof a set of labels:This follows the pattern of the existing
required-checkbox-colclass.Note: duplicated blanks are caught like any other:
Users might do this under the mistaken impression that deleting a label will delete the option (it won't - there's a checkbox for that). Perhaps, as a further PR, we could have a
required-nonblankclass which prints a friendly "Are you trying to delete this field? Try the 'Delete' checkbox!".