Remove upgrade_session_cookie() function #1311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Sep 17, 2025
| // If max length is set, set the cookie timeout - this will allow sessions to outlast browser invocations | ||
| $expiryTime = defined('SESSION_MAXLENGTH_MINS') ? SESSION_MAXLENGTH_MINS * 60 : NULL; | ||
| session_set_cookie_params([ | ||
| 'lifetime'=> $expiryTime, |
Contributor
There was a problem hiding this comment.
Suggested change
| 'lifetime'=> $expiryTime, | |
| 'lifetime' => $expiryTime, |
jefft
force-pushed
the
push-remove-upgrade_session_cookie
branch
2 times, most recently
from
d007ef2 to
8794a35
Compare
jefft
force-pushed
the
push-remove-upgrade_session_cookie
branch
from
8794a35 to
51d3dcf
Compare
jefft
force-pushed
the
push-remove-upgrade_session_cookie
branch
2 times, most recently
from
2b71d77 to
78242fe
Compare
longer supported. In PHP 7.3+ we can set SameSite directly in session_set_cookie_params(), and it's even the default in PHP 8.x. It is also unnecessary to call session_set_cookie_params() before session_regenerate_id(true), as the new cookie already inherits the set cookie params, including SameSite.
jefft
force-pushed
the
push-remove-upgrade_session_cookie
branch
from
78242fe to
d024663
Compare
Contributor
Author
|
Replaced by #1342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jethro has this odd behaviour where it sets the
JethroSesscookie, then immediately deletes it and re-issues it inupgrade_session_cookie. The latter appears to be a later addition, to addSameSite=Laxto previously issued cookies.This PR removes
upgrade_session_cookieand setsJethroSessjust once. In PHP 7.3+ (ref. #1310) we can set SameSite directly in session_set_cookie_params(), and it's even the default in PHP 8.x.It is also unnecessary to call session_set_cookie_params() before session_regenerate_id(true), as the new cookie already inherits the set cookie params, including SameSite.