Service 'Copy from previous' always visible, and previews to-be-copied items #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefft
force-pushed
the
push-972-service-copy-from-previous-preview
branch
from
0134409 to
deae41d
Compare
jefft
force-pushed
the
push-972-service-copy-from-previous-preview
branch
4 times, most recently
from
91ecea5 to
19b6b07
Compare
Contributor
Author
|
Fixed (via force-push) a bug where 'Save' was acting as 'Copy'. |
jefft
force-pushed
the
push-972-service-copy-from-previous-preview
branch
from
19b6b07 to
77338a1
Compare
jefft
force-pushed
the
push-972-service-copy-from-previous-preview
branch
2 times, most recently
from
8038f4e to
dbb9151
Compare
…ght via inline style (if 'height' param is given), because the result is slightly off. This codepath currently used anywhere except service 'Copy from previous'.
just on blank services. The items to be copied is also previewed in the modal. Fixes #972
jefft
force-pushed
the
push-972-service-copy-from-previous-preview
branch
from
dbb9151 to
f452faf
Compare
Contributor
Author
|
Replaced by #1348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #972
'Copy from previous' is now always visible in edit mode:
When 'Copy from previous' is clicked, the modal opens:
UI isn't great, e.g. the title isn't aligned with the preview. I wish I could get rid of that whitespace in the middle. But it works.
Screencast_20250909_180956.webm