Skip to content

Conversation

@jefft
Copy link
Contributor

@jefft jefft commented Sep 3, 2025

I've added some new features to the Service Component Library:

Also, the page now loads the song indicated by the service_componentid URL param. Clicking a song updates the URL with this parameter, so you can bookmark or send a URL to someone.

Todo:

  • Set the page title to the loaded song name, so bookmarks make sens.
  • Change terminology from 'Song' to 'Service Component'
Screencast_20250906_010334.webm

@jefft jefft force-pushed the push-service-component-usage branch from e459af8 to 6fd161e Compare September 5, 2025 07:24
@jefft jefft marked this pull request as draft September 5, 2025 12:18
@jefft jefft force-pushed the push-service-component-usage branch from 6fd161e to fc66ff1 Compare September 5, 2025 14:57
@jefft jefft changed the title Add a 'Services using this song' section to the Service Component Library Add a 'Services using this song' section to the Service Component Library, plus 'Disable' and 'Delete' Sep 5, 2025
@jefft jefft marked this pull request as ready for review September 16, 2025 05:52
@tbar0970
Copy link
Owner

Good ideas. Feedback so far:

  • "Services using this component" ought to be within the song details box, rather than a separate box, I reckon.
  • The delete and disable links ought to have a confirmation popup box (like other 'delete' actions in Jethro). This is also an explanation of what 'disable' means.
  • I wonder if "disable" is the right word. Maybe "archive" is better? I think that's more consistent with the rest of Jethro, eg an archived person isn't in any congregation.

@jefft
Copy link
Contributor Author

jefft commented Sep 16, 2025

Thoughts on thoughts:

"Services using this component" ought to be within the song details box, rather than a separate box, I reckon.

Hm, but the service-song relation is independent of both the service and the song. It isn't "part" of the song, and more than it is "part" of the service. The 'Edit' button doesn't apply to service-song relations:

image

The delete and disable links ought to have a confirmation popup box (like other 'delete' actions in Jethro). This is also an explanation of what 'disable' means.

I don't like confirmation pop-ups (imagine trying to delete 50 CSV-imported songs...), but I guess 'Delete' could have one, since it's a non-reversible operation.

'Disable' is fairly reversible, and the fact that "Congregations" goes blank right before your eyes is a bit of a hint as to how it works. WDYT about leaving 'Disable' popup-free, but immediately replacing it with 'Enable...':

image

then with a modal listing the congregations to re-associate the song with?

I wonder if "disable" is the right word. Maybe "archive" is better? I think that's more consistent with the rest of Jethro, eg an archived person isn't in any congregation.

Well, this business of disassociating congregations is really a hack. From a user's perspective, clicking 'Archive' should archive the song with congregation relations intact, and clicking 'Unarchive' should restore things just how they were.

Perhaps "Disable" and "Enable for.." is more true to the underlying reality than "Archive" and "Unarchive for..". "Unarchive for.." doesn't really make sense.

But whatever you prefer on all this stuff, LMK and I'll tweak the patch!

@jefft jefft force-pushed the push-service-component-usage branch from fc66ff1 to f5a02a8 Compare September 16, 2025 14:13
@jefft jefft closed this Sep 17, 2025
@jefft jefft deleted the push-service-component-usage branch September 17, 2025 02:34
@jefft jefft reopened this Sep 17, 2025
@jefft
Copy link
Contributor Author

jefft commented Sep 17, 2025

I've made two changes:

  • Delete now has a confirmation pop-up
    image
  • 'Disable' has rollover text explaining what it does
  • Disabled songs have an 'Enable' link, that takes one to the song edit page highlighting the Congregations, with instructions to edit them. After editing, one is taken back to the same song in the component library:
Screencast_20250917_151021.webm

PS: The highlight-a-field support is done with newly added hl ("highlight") and hltext URL params, added as a separate commit in this PR.

@jefft jefft force-pushed the push-service-component-usage branch from 4c3e0db to 292d251 Compare September 17, 2025 10:31
… lets AJAX calls to pages tell if something went wrong
…param.

In the component library list, track the clicked song in the URL, so that the hyperlink can be shared.
When a new song is created, automatically load it in the component library.
…tion associations, and is only shown if congregation assocs exist. 'Delete' only shows if no service items use this service component.
with help text ('hltext') suggesting what needs to be done.
…isable' was) taking one to the song edit page, highlighting that the congregations need to be picked
@jefft jefft force-pushed the push-service-component-usage branch from 292d251 to 1712c9d Compare September 26, 2025 05:57
@tbar0970 tbar0970 merged commit e545152 into tbar0970:master Oct 12, 2025
tbar0970 added a commit that referenced this pull request Oct 12, 2025
@tbar0970
Copy link
Owner

tbar0970 commented Oct 12, 2025

Layout issue:
On a mid size laptop screen, the usage box shows on the left
image

(This would be solved by putting the usage info into the same box as the other stuff ;-) )

@jefft
Copy link
Contributor Author

jefft commented Oct 12, 2025

Layout issue:
On a mid size laptop screen, the usage box shows on the left

I created #1333 to fix this.

tbar0970 added a commit that referenced this pull request Oct 14, 2025
'Services using this song' box should always be on the right. #1290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants