-
Notifications
You must be signed in to change notification settings - Fork 29
Add a 'Services using this song' section to the Service Component Library, plus 'Disable' and 'Delete' #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e459af8 to
6fd161e
Compare
6fd161e to
fc66ff1
Compare
Owner
|
Good ideas. Feedback so far:
|
Contributor
Author
fc66ff1 to
f5a02a8
Compare
Contributor
Author
4c3e0db to
292d251
Compare
… lets AJAX calls to pages tell if something went wrong
…param. In the component library list, track the clicked song in the URL, so that the hyperlink can be shared. When a new song is created, automatically load it in the component library.
…don't treat it as a song load
…tion associations, and is only shown if congregation assocs exist. 'Delete' only shows if no service items use this service component.
with help text ('hltext') suggesting what needs to be done.
…isable' was) taking one to the song edit page, highlighting that the congregations need to be picked
292d251 to
1712c9d
Compare
tbar0970
added a commit
that referenced
this pull request
Oct 12, 2025
Owner
Contributor
Author
I created #1333 to fix this. |
tbar0970
added a commit
that referenced
this pull request
Oct 14, 2025
'Services using this song' box should always be on the right. #1290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




I've added some new features to the Service Component Library:
Also, the page now loads the song indicated by the
service_componentidURL param. Clicking a song updates the URL with this parameter, so you can bookmark or send a URL to someone.Todo:
Screencast_20250906_010334.webm