feat: add ability for top document in a YAML file to merge down #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelboulton
force-pushed
the
feat/803/top-document-merge-down
branch
from
bbb3141 to
032ca47
Compare
michaelboulton
force-pushed
the
feat/803/top-document-merge-down
branch
from
3f28cbb to
27f4294
Compare
michaelboulton
force-pushed
the
feat/803/top-document-merge-down
branch
from
27f4294 to
aa5168e
Compare
michaelboulton
force-pushed
the
feat/803/top-document-merge-down
branch
from
478d603 to
bf7845c
Compare
chore: remove redundant code and update merge logic feat: add support for merging test specs feat: add logging for merging initial block in YamlFile feat: add test for redirecting loops feat: Add unit test for multiple documents in YAML file fix: Import Mock in test_files.py fix: handle errors in YamlFile class test: refactor test file handling and add multiple document support refactor: Move Opener class outside of TestGenerateFiles test: add exception handling and improve test structure docs: Add docstring to test_reraise_exception function fix: Simplify exception test description
refactor: update import path for start_mark
…ML document in test file - The loop variable `i` has been renamed to `document_idx` to better reflect its purpose, which is to track the index of the YAML document being processed. - A comment has been added to explain the implicit behavior when the first YAML document has no "stages" but may have other properties like "name". - The variable `merge_down` is now correctly initialized and used based on the index of the document being processed.
michaelboulton
force-pushed
the
feat/803/top-document-merge-down
branch
from
bf7845c to
e853e8d
Compare
…cuments - Introduced a new `is_defaults` marker in YAML documents for specifying defaults explicitly. - Enhanced validation to ensure the `defaults` marker is only used in the first YAML document. - Updated error handling to raise schema errors when required sections (`stages` or `test_name`) are missing in any document. - Modified `merge_down` logic to incorporate explicit `defaults` marker where applicable. - Updated `tests.jsonschema.yaml` to include `defaults` property for schema validation of YAML documents. - Adjusted unit tests in `test_files.py` to account for the new `is_defaults` behavior.
… `_core/plugins.py` - Added type annotations to `plugins`, `session_spec`, `formatted`, and `request_class` for clarity and type safety. - Introduced an explicit `None` check for `request_class` and raised a `MissingSettingsError` if no request type is found. - Improved code readability and robustness with explicit variable typing and error validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#803