Skip to content

Raise an error and log it if test timeouts are set incorrectly #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

Raise an error and log it if test timeouts are set incorrectly #397

merged 1 commit into from
Jul 13, 2023

Conversation

i-cod
Copy link
Contributor

@i-cod i-cod commented Jun 29, 2023 •
edited
Loading

Added logic that abort test run and logs an error message if
condition is not met: no-output-timeout is at least 10 seconds
longer than test-timeout and test-timeout is at least 10 seconds
longer than server-start-timeout.

Closes #250

@i-cod i-cod requested a review from ylobankov June 29, 2023 10:50
@i-cod i-cod force-pushed the i-cod/timeout-adjustment branch 2 times, most recently from d39dfa7 to dc17c4c Compare June 29, 2023 11:07
ochaplashkin
ochaplashkin reviewed Jul 4, 2023
View reviewed changes
@ochaplashkin
Copy link

ochaplashkin commented Jul 4, 2023 •
edited
Loading

  1. Please add the issue number to the commit message;
  2. It also seems to me that the description of the PR does not need to be copied from the commit message. (it is possible when a very simple change is made, e.g. bump version).

ochaplashkin
ochaplashkin reviewed Jul 4, 2023
View reviewed changes
@i-cod i-cod force-pushed the i-cod/timeout-adjustment branch 2 times, most recently from fa805ed to ac6e476 Compare July 5, 2023 14:32
@i-cod i-cod changed the title Correcting timeouts when changing default values Raise an error and log it if test timeouts are set incorrectly Jul 5, 2023
ylobankov
ylobankov reviewed Jul 7, 2023
View reviewed changes
@i-cod i-cod force-pushed the i-cod/timeout-adjustment branch 2 times, most recently from 2489d5b to e33f3bc Compare July 12, 2023 09:22
Raise an error and log it if test timeouts are set incorrectly
4025170 
Added logic that abort test run and logs an error message if
condition is not met: no-output-timeout is at least 10 seconds
longer than test-timeout and test-timeout is at least 10 seconds
longer than server-start-timeout.

Closes #250
@i-cod i-cod force-pushed the i-cod/timeout-adjustment branch from e33f3bc to 4025170 Compare July 13, 2023 10:19
ochaplashkin
ochaplashkin approved these changes Jul 13, 2023
View reviewed changes
Copy link

@ochaplashkin ochaplashkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ochaplashkin ochaplashkin merged commit d34ecb0 into master Jul 13, 2023
@ochaplashkin ochaplashkin deleted the i-cod/timeout-adjustment branch July 13, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada left review comments

@ylobankov ylobankov ylobankov left review comments

@ochaplashkin ochaplashkin ochaplashkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give a warning when configured timeouts look strange
4 participants
@i-cod @ochaplashkin @Totktonada @ylobankov