Add RSS memory status collecting routine to get RSS per tests and workers #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtikhon
force-pushed
the
avtikhon/gh-qa-98-rss-collect
branch
3 times, most recently
from
6525c15 to
452c434
Compare
avtikhon
force-pushed
the
avtikhon/gh-qa-98-rss-collect
branch
from
d03d3fd to
17d2b6b
Compare
avtikhon
force-pushed
the
avtikhon/gh-qa-98-rss-collect
branch
from
17d2b6b to
dd030dd
Compare
Added RSS memory status collecting routine which parses file: /sys/fs/cgroup/memory/memory.stat for RSS value and run this routine after each sent test lua command in listeners. All results it collects in main tests worker log file: var/log/<worker name>.log For this routine use added test-run new option: --collect-statistics which should be used to use this routine. Closes tarantool/tarantool-qa#98
Found that TAP test do not print any information on tested conditions in tests worker log file. It can be used to check test stages for data written into this log file.
avtikhon
force-pushed
the
avtikhon/gh-qa-98-rss-collect
branch
from
dd030dd to
d9d7124
Compare
avtikhon
added
do not merge
|
I clarified the task: I want a built-in tool that will spot tests that use large amount of memory and will be enabled always: locally and in CI. So it should not be under an option and should be cheap enough (not after each command). Sure, we may want a tool that will allow in-depth analysis, but it is not my primary wish. It is also possible that we'll get enough information in test-run logs after #298: we'll see commands and samples on the same timeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch set consists of 2 commits:
Add RSS memory status collecting routine
Added RSS memory status collecting routine which parses file:
/sys/fs/cgroup/memory/memory.statfor RSS value and run this routine after each sent test lua command in
listeners. All results it collects in main tests worker log file:
var/log/<worker name>.logFor this routine use added test-run new option:
--collect-statisticswhich should be used to use this routine.
Closes resources: flaky issues on lack of memory tarantool-qa#98
Enable logging TAP tests on each testing condition
Found that TAP test do not print any information on tested conditions
in tests worker log file. It can be used to check test stages for
data written into this log file.