color_log() output don't shown on the terminal with --debug when called from the main process

[Totktonada]

We should tune the behaviour here:

test-run/lib/colorer.py

Lines 218 to 219 in e843552

	elif not log_only:
	self.stdout.write(obj)

Depending on whether --debug was passed.

[Totktonada]

The obvious fix:

diff --git a/lib/__init__.py b/lib/__init__.py
index dcfe149..3bf3fca 100644
--- a/lib/__init__.py
+++ b/lib/__init__.py
@@ -2,6 +2,7 @@ import os
 import sys
 import shutil
 
+from lib.colorer import colorer_cfg
 from lib.options import Options
 from lib.tarantool_server import TarantoolServer
 from lib.unittest_server import UnittestServer
@@ -26,6 +27,8 @@ def setenv():
 def module_init():
     """ Called at import """
     args = Options().args
+    colorer_cfg(copy_log_to_stdout=args.debug)
+
     # Change the current working directory to where all test
     # collections are supposed to reside
     # If script executed with (python test-run.py) dirname is ''
diff --git a/lib/colorer.py b/lib/colorer.py
index 48ab560..091151f 100644
--- a/lib/colorer.py
+++ b/lib/colorer.py
@@ -7,6 +7,19 @@ import sys
 color_stdout = None  # = Colorer(); below the class definition
 
 
+cfg = dict()
+cfg_opts = ['copy_log_to_stdout']
+
+
+def colorer_cfg(**kwargs):
+    global cfg
+    for k in cfg_opts:
+        if k in kwargs:
+            cfg[k] = kwargs[k]
+        else:
+            raise ValueError('Unknown colorer option {}'.format(k))
+
+
 def color_log(*args, **kwargs):
     """ Print the message only to log file, not on the screen. The intention is
     use this function only for regular, non-error output that appears every run
@@ -15,7 +28,7 @@ def color_log(*args, **kwargs):
     exceptional circumstances) from the screen, because such details especially
     useful with CI bots.
     """
-    kwargs['log_only'] = True
+    kwargs['log_only'] = not cfg['copy_log_to_stdout']
     color_stdout(*args, **kwargs)

The logs from the main process still not written to any log file. It should be fixed here or should be tracked in a separate issue.

[Totktonada]

Sorry for those "I'll show you a patch" suggestions. I just heard something about imports on a meeting today and was curious, why we need to import options into the colorer. It seems, we don't: I would can just reverse the dependency.

[Totktonada]

NB: Don't forget to remove the following line:

test-run/lib/sampler.py

Line 144 in d7eff44

# Those logs are not written due to gh-247.

But only when the problem will be fully resolved. Checklist:

1. Logs from the main process are written to a file (which will be placed to artifacts afterwards).
2. When --debug is passed, those logs are additionally shown on the screen (it is what the patch above does).