debian/scripts/tarantool_instance : do not override PID file location #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can just use the default location of $(pwd)/tarantool.pid. Since we chdir to /var/lib/tarantool/snapshot/$NAME, the new PID file location would be /var/lib/tarantool/$INSTANCE/tarantool.pid.
|
Sorry, wrong branch. |
|
Not wrong branch. I assumed you had a separate debian packaging branch for some reason. |
|
FHS defines several directories for PID-files. /var/lib is not fit for PID-file. |
llelik8
pushed a commit
that referenced
this pull request
Feb 21, 2018
close gh-290 (Document replication_timeout variable)
Totktonada
added a commit
that referenced
this pull request
Apr 7, 2021
List of changes in test-run: * readme: add memcached to users ([PR #285][1]) * test: add integration tests ([PR #273][2]) * test: enable in continuous integration ([PR #273][2]) * Fix slowdown on Python 3 ([PR #290][3]) Updated .luacheckrc to exclude newly added 'core = tarantool' tests (ones that check test-run itself). [1]: tarantool/test-run#285 [2]: tarantool/test-run#273 [3]: tarantool/test-run#290
Totktonada
added a commit
that referenced
this pull request
Apr 7, 2021
List of changes in test-run: * readme: add memcached to users ([PR #285][1]) * test: add integration tests ([PR #273][2]) * test: enable in continuous integration ([PR #273][2]) * Fix slowdown on Python 3 ([PR #290][3]) Updated .luacheckrc to exclude newly added 'core = tarantool' tests (ones that check test-run itself). [1]: tarantool/test-run#285 [2]: tarantool/test-run#273 [3]: tarantool/test-run#290 (cherry picked from commit 8b3ec7b)
Totktonada
added a commit
that referenced
this pull request
Apr 7, 2021
List of changes in test-run: * readme: add memcached to users ([PR #285][1]) * test: add integration tests ([PR #273][2]) * test: enable in continuous integration ([PR #273][2]) * Fix slowdown on Python 3 ([PR #290][3]) Updated .luacheckrc to exclude newly added 'core = tarantool' tests (ones that check test-run itself). [1]: tarantool/test-run#285 [2]: tarantool/test-run#273 [3]: tarantool/test-run#290 (cherry picked from commit 8b3ec7b)
Totktonada
added a commit
that referenced
this pull request
Apr 7, 2021
List of changes in test-run: * readme: add memcached to users ([PR #285][1]) * test: add integration tests ([PR #273][2]) * test: enable in continuous integration ([PR #273][2]) * Fix slowdown on Python 3 ([PR #290][3]) Updated .luacheckrc to exclude newly added 'core = tarantool' tests (ones that check test-run itself). [1]: tarantool/test-run#285 [2]: tarantool/test-run#273 [3]: tarantool/test-run#290 (cherry picked from commit 8b3ec7b) (The .luacheckrc change was excluded from the backport to 1.10: there is no .luacheckrc here.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can just use the default location of $(pwd)/tarantool.pid. Since we chdir to /var/lib/tarantool/snapshot/$INSTANCE, the new PID file location would be /var/lib/tarantool/$INSTANCE/tarantool.pid.