test: stabilize replication rebootstrap and bootstrap_leader tests #10988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 89cd7f4 ("replication: do not account booting replicas in sync quorum") allowed replicas to leave orphan mode without waiting for everyone listed in box.cfg.replication. As a result, bootstrap_leader test started exiting too early, because it relied on one of the replicas staying in orphan mode until all the others finish bootstrap. Fix it. Also, remove "memtx" and "vinyl" configuration for the test. There is nothing in the test related to engines. While we're at it, remove the test from fragile list. It hasn't flaked since long ago, excluding the last couple of weeks, which's fixed now. Closes tarantool/tarantool-qa#63 NO_CHANGELOG=flaky test NO_DOC=flaky test
The commit 89cd7f4 ("replication: do not account booting replicas in sync quorum") allowed replicas to leave orphan mode without waiting for everyone listed in box.cfg.replication. As a result, bootstrap_leader test started exiting too early, because it relied on one of the replicas staying in orphan mode until all the others finish bootstrap. Fix it. While we're at it, remove the test from fragile list. It hasn't flaked since long ago, excluding the last couple of weeks, which's fixed now. Closes tarantool/tarantool-qa#56 NO_CHANGELOG=flaky test NO_DOC=flaky test
sergepetrenko
force-pushed
the
bootstrap-leader-test-fix
branch
from
250e319 to
4aabceb
Compare
sergepetrenko
changed the title
|
@Serpentian, the next flaky test I picked up ended up having the exact same problem and solution. I've added a fix in a separate commit. PTAL |
Serpentian
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 89cd7f4 ("replication: do not account booting replicas in sync quorum") allowed replicas to leave orphan mode without waiting for everyone listed in box.cfg.replication.
As a result, bootstrap_leader test started exiting too early, because it relied on one of the replicas staying in orphan mode until all the others finish bootstrap. Fix it.
Also, remove "memtx" and "vinyl" configuration for the test. There is nothing in the test related to engines.
While we're at it, remove the test from fragile list. It hasn't flaked since long ago, excluding the last couple of weeks, which's fixed now.
Closes tarantool/tarantool-qa#63
NO_CHANGELOG=flaky test
NO_DOC=flaky test