Skip to content

ci: use python 3 in reusable_testing.yml workflow #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

ylobankov
Copy link
Contributor

@ylobankov ylobankov commented Jan 20, 2022

The memcached tests have migrated to Python 3 recently in scope of #82.
But reusable_testing.yml workflow wasn't updated and tests started to
fail. This patch fixes the issue.

@ligurio
Copy link
Member

ligurio commented Jan 20, 2022

#82 introduced Python 3 without breaking compatibility with Python 2, so it should work in general.

There is a typo in commit message "This path".

LGTM

The memcached tests have migrated to Python 3 recently in scope of #82.
But reusable_testing.yml workflow wasn't updated and tests started to
fail. This patch fixes the issue.
@ylobankov ylobankov force-pushed the ylobankov/fix-reusable-testing-wf branch from bf2bbdf to 1c7ab42 Compare January 20, 2022 17:09
@ylobankov
Copy link
Contributor Author

#82 introduced Python 3 without breaking compatibility with Python 2, so it should work in general.

There is a typo in commit message "This path".

LGTM

Typo is fixed, thanks!

In reusable_testing.yml workflow, we set up python2 for testing, but the test-run version was updated in #83 and now tests are run via python3. So we had missing dependencies because all of them were installed in python2 env.

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Am I understand right, the problem is just in shebang in the main test-run script?

@Totktonada Totktonada merged commit 19711c3 into master Jan 20, 2022
@Totktonada Totktonada deleted the ylobankov/fix-reusable-testing-wf branch January 20, 2022 18:03
@ylobankov
Copy link
Contributor Author

LGTM.

Am I understand right, the problem is just in shebang in the main test-run script?

Yes, you're right.

@Totktonada
Copy link
Member

It is the weird story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants