mdm: define OnboardingFlow syspolicy on Android #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Revisions
☑️ AI review skipped after 5 revisions, comment with `/review` to review again HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
![review-ai-agent[bot]](https://avatars.githubusercontent.com/in/1104228?s=60&v=4){kind=small}
nickkhyl
reviewed
May 12, 2025
zbuchheit
force-pushed
the
zbuchheit/skip-intro-screen
branch
from
fed79d4 to
ae71490
Compare
zbuchheit
force-pushed
the
zbuchheit/skip-intro-screen
branch
from
ae71490 to
3511552
Compare
zbuchheit
force-pushed
the
zbuchheit/skip-intro-screen
branch
2 times, most recently
from
2d54d76 to
63ff494
Compare
barnstar
requested changes
May 20, 2025
There was a problem hiding this comment.
Thank you @zbuchheit !
Just a few small changes to use the existing policy name for consistency with other platforms.
Adds an MDM setting `OnboardingFlow` which allows for the intro screen to be skipped when set to true. Adds MDM Setting update to the top of MainActivity onCreate to ensure the latest MDMSettings are accurate. When attempting to do this while relying on MDMSettings being update during onResume it created a race condition where occasionally OnboardingFlow was being evaluated to the default value `show` when in reality it should be set to `hide`. Signed-off-by: zbuchheit <[email protected]>
zbuchheit
force-pushed
the
zbuchheit/skip-intro-screen
branch
from
63ff494 to
42a4de1
Compare
zbuchheit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an MDM setting
OnboardingFlowwhich allows for the intro screen to be skipped when set to true.Adds MDM Setting update to the top of MainActivity onCreate to ensure the latest MDMSettings are accurate.
When attempting to rely on MDMSettings being updated during
onResumeit created a race condition where occasionally OnboardingFlow was being evaluated to the default valueshowwhen in reality it should be set tohide.Updates https://github.com/tailscale/corp/issues/27966