Skip to content

Silence deprecation warning #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Conversation

kornelski
Copy link
Contributor

This method has been replaced by source()

@tailhook tailhook merged commit aadd84f into tailhook:master Jan 8, 2019
@tailhook
Copy link
Owner

tailhook commented Jan 8, 2019

Thanks!

@kornelski kornelski deleted the deprecated branch January 8, 2019 13:43
@dvic
Copy link

dvic commented Jan 23, 2019

@tailhook I'm not sure the way this is usually handled but shouldn't we introduce a feature flag for also implementing source()? (for Rust 1.30 and above).

@kornelski
Copy link
Contributor Author

Source would be nice, but I'm not sure how to deal with breaking changes and existing cause() syntax in quick-error.

Should quick-error's cause() generate source() implementation? What if lifetimes don't match?

Should the macro include a new, separate source() syntax?

@tailhook
Copy link
Owner

Yes, good question. Probably, I'd expect separate source() syntax. This would allow backwards compatibility with old rust, I think (i.e. don't add source method if it isn't mentioned in the macro).

@kornelski
Copy link
Contributor Author

BTW, @tailhook I'd love to help, but the macro is intimidating. Could you add comments what each case in the macro does? What is the queue, chunks, and the bunch of upper-case keywords?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants