Skip to content

Missing argument 2 (default build name) in webpack_encore.entrypoint_lookup_collection #70

Closed
@weaverryan

Description

@weaverryan

For the webpack_encore.entrypoint_lookup_collection service, we're currently NEVER passing the 2nd argument: $defaultBuildName. In WebpackEncoreExtension, we should set this argument to _default inside this if statement:

if (false !== $config['output_path']) {
$factories['_default'] = $this->entrypointFactory($container, '_default', $config['output_path'], $config['cache'], $config['strict_mode']);
$cacheKeys['_default'] = $config['output_path'].'/'.self::ENTRYPOINTS_FILE_NAME;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugBug Fix

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions