Skip to content

Conversation

@swistakm
Copy link
Owner

@swistakm swistakm commented Nov 14, 2016

Initial implementation of optional context handling.

TODO: documentation.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8b42b25 on feature/optional-context-handling into 4d8469c on master.

@tomislater
Copy link
Collaborator

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 869ebfd on feature/optional-context-handling into 4d8469c on master.

Copy link
Collaborator

@mihau mihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the docstring typo it's cool.


These handlers do not have the direct access to the request and response
objects (the ``req`` and ``resp`` arguments). In most cases this is not a
proble,. Access to the request object is required usually in order to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proble, > problem

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 826e94f on feature/optional-context-handling into 4d8469c on master.

@swistakm swistakm merged commit dbc2d6f into master Nov 16, 2016
@swistakm swistakm deleted the feature/optional-context-handling branch January 11, 2017 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants