IRGen: Fix assertion failure with typed throws #80273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapTypeIntoContext() call in visitFullApplySite() was not necessary. The type in question is already fully substituted and should no longer contain type parameters. However, it can contain archetypes, which is what caused mapTypeIntoContext() to assert. Indeed, this case where the return type is generic but still loadable wasn't covered by our test suite. - Fixes swiftlang#80020. - Fixes rdar://147051717.
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
CC @drexin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from f6e7c16. The mapTypeIntoContext() call in visitFullApplySite() was not necessary because the type in question is already fully substituted and should no longer contain type parameters.
However, it can contain archetypes, which is what caused mapTypeIntoContext() to assert. Indeed, this case where the return type is generic but still loadable wasn't covered by our test suite.
(I believe the other places where mapTypeIntoContext() was introduced in that commit are correct, because there we're dealing with the interface type of the current function, which can contain type parameters.)