Skip to content

[5.9] [SourceKit] Record module loading errors when generating interfaces #66700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamishknight
Copy link
Contributor

5.9 cherry-pick of #66676

  • Explanation: Improves the error message we produce when we fail to load a module for a generated interface.
  • Scope: Affects error handling logic of generated interfaces.
  • Issue: rdar://109511099
  • Risk: Low, only affects the error handling logic of generated interfaces
  • Testing: Added tests to test suite
  • Reviewer: Alex Hoppen

Record up to two errors emitted when we fail to
load a module for interface generation, and include
these errors in the message we pass back to the
editor. This should help us better pin down the
reason why interface generation failed.

rdar://109511099
@hamishknight hamishknight requested a review from a team as a code owner June 16, 2023 09:34
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit f1bf558 into swiftlang:release/5.9 Jun 16, 2023
@hamishknight hamishknight deleted the interface-error-5.9 branch June 16, 2023 14:42
@hamishknight hamishknight added swift 5.9 🍒 release cherry pick Flag: Release branch cherry picks labels Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants