[Runtime] Add tracing for section scans. #66377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
I think this needs some availability checks. |
|
We check a representative symbol for NULL instead, but of course the compiler doesn't know that. The signpost stuff in the concurrency runtime disables the availability warnings, I'll do the same here. |
mikeash
force-pushed
the
section-scan-signposts
branch
from
8ab85e0 to
8d0fa6f
Compare
|
@swift-ci please test |
al45tair
approved these changes
Jun 7, 2023
|
@swift-ci please smoke test |
|
I keep forgetting to look at the failures until after they expire. |
|
@swift-ci please smoke test |
|
Finally got it: We must not be tolerating NULL somewhere we need to. |
mikeash
force-pushed
the
section-scan-signposts
branch
from
8d0fa6f to
e8f334b
Compare
|
@swift-ci please test and merge |
Section scans (for metadata, protocols, etc.) can be costly. This change adds tracing calls to those scans so we can more easily see how much time is spent in these scans and where they're initiated. This adds an os_signpost implementation controlled by SWIFT_STDLIB_TRACING, and a default empty implementation for when that's disabled. rdar://110266743
mikeash
force-pushed
the
section-scan-signposts
branch
from
e8f334b to
110f428
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section scans (for metadata, protocols, etc.) can be costly. This change adds tracing calls to those scans so we can more easily see how much time is spent in these scans and where they're initiated.
This adds an os_signpost implementation controlled by SWIFT_STDLIB_TRACING, and a default empty implementation for when that's disabled.
rdar://110266743