Skip to content

Fix CLion getting started, swift-syntax is also required now #62252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Nov 26, 2022

Also include the swift-syntax path, otherwise CMake import in CLion will fail.

Also include the swift-syntax path, otherwise CMake import in CLion will fail.
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I wonder if the CMake scripts could assume that the dependency projects are located in the same directory as Swift itself by default, that would make it more convenient for people to build Swift with CMake directly.

@ktoso
Copy link
Contributor Author

ktoso commented Nov 28, 2022

Yeah that sounds like a safe thing to assume tbh. I'll do a follow up ticket for it

@ktoso
Copy link
Contributor Author

ktoso commented Nov 28, 2022

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Nov 29, 2022

Follow up here: #62291

@ktoso
Copy link
Contributor Author

ktoso commented Nov 29, 2022

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 279e241 into main Nov 29, 2022
@swift-ci swift-ci deleted the ktoso-patch-14 branch November 29, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants