-
Notifications
You must be signed in to change notification settings - Fork 10.5k
libswift: add support for Android and OpenBSD in the CMake config #40277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sure, happy to test this for OpenBSD with some guidance on how to run a bootstrap build. |
I just built the latest trunk tag normally and it chooses the bootstrap build by default. |
Interesting. Is Android used as a host platform? I.e. is the swift compiler itself built on an Android system? |
Yes, I periodically build a trunk Swift toolchain natively on my Android phone and spin off patches like these to submit here. I also maintain the Termux package that provides a prebuilt toolchain for the Termux app on Android. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
b37551f
to
e3f088d
Compare
I've extended this pull to support both Let me know what you think of how I structured this. |
Reworked this pull to add a new libswift build mode for non-Darwin cross-compilation instead, taking your lead from the now-closed #40308. Ready for review, let me know what you think. |
Add a new libswift build mode for cross-compilation in the process, that currently only works for non-Darwin hosts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Please make sure to also test the "hosttools" mode locally. It's not tested in CI
Squashed the commits into one, can you run the CI? I haven't tried "hosttools" mode on Android, but @3405691582 reported it worked for him on OpenBSD, so I figure it'll work for me too. |
@MaxDesiatov, would you run the CI on this? |
@swift-ci please smoke test |
Passed CI, can be merged now. |
@eeckstein, would you merge? |
Add a new libswift build mode for cross-compilation in the process, that currently only works for non-Darwin hosts.
@3405691582,
let me know if you'd like me toadded OpenBSD too.@eeckstein, this modifies your pull #39461 to add support for Android, which I just built the Nov. 19 source snapshot natively on. When you get back from Thanksgiving, let me know what you think.