libswift: fixes and improvements for the bootstrapping build #40068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't build the swiftCore module files in the bootstrapping phases. Instead use the module files in the SDK. This reduces the build time overhead from 3min -> 30seconds.
swiftDarwin and swiftOnoneSupport didn't depend on building the Swift core library. This was a subtle bug, because the compiler just picked up the module from the SDK instead of the (still building) Swift module. It only resulted in compiler errors if the SDK swiftinterface was too new to be parsable by the compiler.
|
@swift-ci smoke test |
gottesmm
reviewed
Nov 6, 2021
| @@ -117,6 +117,12 @@ function(add_bootstrapping_target bootstrapping) | |||
| set(target "bootstrapping${bootstrapping}-all") | |||
| add_custom_target(${target}) | |||
|
|
|||
| if(${LIBSWIFT_BUILD_MODE} STREQUAL "BOOTSTRAPPING") | |||
gottesmm
reviewed
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details see the commit messages