[NFC] Fix Projection print for Enum kind #32328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
gottesmm
reviewed
Jun 11, 2020
lib/SIL/Utils/Projection.cpp
Outdated
| @@ -549,13 +549,21 @@ ProjectionPath::removePrefix(const ProjectionPath &Path, | |||
| } | |||
|
|
|||
| void Projection::print(raw_ostream &os, SILType baseType) const { | |||
| if (isNominalKind()) { | |||
| if (getKind() == ProjectionKind::Struct || | |||
There was a problem hiding this comment.
Could you make this an exhaustive switch?
|
Other than that LGTM! I am assuming that the RLE dumper issue is exposed by further work in other PRs? Which PR specifically? Or can you link it to this one by mentioning this PR there? |
|
@gottesmm This came up while working on some regressions with semantic inlining. Don't have a PR to link yet. |
|
@swift-ci smoke test |
|
@swift-ci smoke test OSX |
1 similar comment
|
@swift-ci smoke test OSX |
|
@swift-ci Please smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProjectionKind::Enum was handled incorrectly causing RLE's debug print to crash