[SIL] NFC: Make SILVTable follow C++ and LLVM best practices #32296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davezarzycki
requested review from
slavapestov,
jckarter,
gottesmm and
eeckstein
|
@swift-ci please smoke test |
jckarter
reviewed
Jun 10, 2020
include/swift/SIL/SILModule.h
Outdated
| @@ -178,7 +178,7 @@ class SILModule { | |||
| llvm::DenseMap<const ClassDecl *, SILVTable *> VTableMap; | |||
|
|
|||
| /// The list of SILVTables in the module. | |||
| VTableListType vtables; | |||
| std::vector<SILVTable*> vtables; | |||
There was a problem hiding this comment.
If we're following LLVM best practices, maybe this should be a SmallVector?
There was a problem hiding this comment.
That change was from the prior pull request but otherwise yes that could be a SmallVector
There was a problem hiding this comment.
Would you like me to change it? If so, then what should the magic SmallVector constant be?
There was a problem hiding this comment.
Hm, it's probably fine as a std::vector come to think of it. It's hard to think of a reasonable small threshold of number of vtables that most modules would hold.
1) Convert the `Entry` type to a class with getters/setters 2) Use llvm::TrailingObjects 3) Use llvm::PointerIntPair
|
@swift-ci please smoke test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entrytype to a class with getters/settersThis builds on #32238, so please ignore that commit (or comment on that PR).